linux-kernel - Re: [PATCH v3 09/11] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240320101725.464327-1-bhargav.r@ltts.com>
Date: Wed, 20 Mar 2024 15:47:25 +0530
From: Bhargav Raviprakash <bhargav.r@...s.com>
To: dan.carpenter@...aro.org
Cc: arnd@...db.de,
	bhargav.r@...s.com,
	broonie@...nel.org,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	eblanc@...libre.com,
	gregkh@...uxfoundation.org,
	jpanis@...libre.com,
	kristo@...nel.org,
	krzysztof.kozlowski+dt@...aro.org,
	lee@...nel.org,
	lgirdwood@...il.com,
	linus.walleij@...aro.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	m.nirmaladevi@...s.com,
	nm@...com,
	robh+dt@...nel.org,
	vigneshr@...com
Subject: Re: [PATCH v3 09/11] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators

Hello,

On Thu, 14 Mar 2024 16:30:09 +0300, Dan Carpenter wrote:
> On Fri, Mar 08, 2024 at 04:04:53PM +0530, Bhargav Raviprakash wrote:
> > @@ -374,11 +518,17 @@ static int tps6594_request_reg_irqs(struct platform_device *pdev,
> >  {
> >  	struct tps6594_regulator_irq_type *irq_type;
> >  	struct tps6594 *tps = dev_get_drvdata(pdev->dev.parent);
> > -	int j;
> > +	size_t j;
> >  	int irq;
> >  	int error;
> > +	size_t interrupt_cnt;
> > +
> > +	if (tps->chip_id == TPS6594)
> > +		interrupt_cnt = ARRAY_SIZE(tps6594_buck1_irq_types);
> > +	else
> > +		interrupt_cnt = ARRAY_SIZE(tps65224_buck1_irq_types);
>                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> >  
> > -	for (j = 0; j < REGS_INT_NB; j++) {
> > +	for (j = 0; j < interrupt_cnt; j++) {
> >  		irq_type = &tps6594_regs_irq_types[j];
>                             ^^^^^^^^^^^^^^^^^^^^^^
> >  		irq = platform_get_irq_byname(pdev, irq_type->irq_name);
> >  		if (irq < 0)
> 
> The tps6594_regs_irq_types pointer needs to be renamed or people won't
> know it's holding tps65224_ data.  Probably the function should be
> renamed too.
> 
> regards,
> dan carpenter

Thanks for the feedback! The name will be changed in the next version.

Regards,
Bhargav