[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240320192055.6b149d90ca3af255aa7738ab@kernel.org>
Date: Wed, 20 Mar 2024 19:20:55 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Ye Bin <yebin10@...wei.com>
Cc: <rostedt@...dmis.org>, <mathieu.desnoyers@...icios.com>,
<linux-trace-kernel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 0/8] support '%pd' and '%pD' for print file name
Hi Ye,
On Fri, 15 Mar 2024 14:55:32 +0800
Ye Bin <yebin10@...wei.com> wrote:
> Sorry for taking so long to post the V6 version. I thought my email was
> sent successfully. I checked the patchwork and it was not sent successfully.
>
> During fault locating, the file name needs to be printed based on the
> dentry/file address. The offset needs to be calculated each time, which
> is troublesome. Similar to printk, kprobe supports printing file names
> for dentry/file addresses.
Thanks for updating the series.
There are some nits, but basically this is good to me.
Could you update this series?
Thank you,
>
> Diff v6 vs v5:
> 1. Add const for 'bufsize' in PATCH [1];
> 2. Move PATCH 'tracing/probes: support '%pd/%pD' type for fprobe' after
> PATCH "tracing/probes: support '%pd' type for print struct dentry's name".
> 3. Add requires '"%pd/%pD":README' for testcase.
>
> Diff v5 vs v4:
> 1. Use glob_match() instead of str_has_suffix(), so remove the first patch;
> 2. Allocate buffer from heap for expand dentry;
> 3. Support "%pd/%pD" print type for fprobe;
> 4. Use $arg1 instead of origin register in test case;
> 5. Add test case for fprobe;
>
> Diff v4 vs v3:
> 1. Use "argv[i][idx + 3] == 'd'" instead of "argv[i][strlen(argv[i]) - 1] == 'd'"
> to judge print format in PATCH[4/7];
>
> Diff v3 vs v2:
> 1. Return the index of where the suffix was found in str_has_suffix();
>
> Diff v2 vs v1:
> 1. Use "%pd/%pD" print format instead of "pd/pD" print format;
> 2. Add "%pd/%pD" in README;
> 3. Expand "%pd/%pD" argument before parameter parsing;
> 4. Add more detail information in ftrace documentation;
> 5. Add test cases for new print format in selftests/ftrace;
>
> Ye Bin (8):
> tracing/probes: add traceprobe_expand_dentry_args() helper
> tracing/probes: support '%pd' type for print struct dentry's name
> tracing/probes: support '%pd' type for fprobe
> tracing/probes: support '%pD' type for print struct file's name
> tracing: add new type "%pd/%pD" in readme_msg[]
> Documentation: tracing: add new type '%pd' and '%pD' for kprobe
> selftests/ftrace: add kprobe test cases for VFS type "%pd" and "%pD"
> selftests/ftrace: add fprobe test cases for VFS type "%pd" and "%pD"
>
> Documentation/trace/kprobetrace.rst | 8 ++-
> kernel/trace/trace.c | 2 +-
> kernel/trace/trace_fprobe.c | 6 ++
> kernel/trace/trace_kprobe.c | 6 ++
> kernel/trace/trace_probe.c | 63 +++++++++++++++++++
> kernel/trace/trace_probe.h | 2 +
> .../ftrace/test.d/dynevent/fprobe_args_vfs.tc | 40 ++++++++++++
> .../ftrace/test.d/kprobe/kprobe_args_vfs.tc | 43 +++++++++++++
> 8 files changed, 167 insertions(+), 3 deletions(-)
> create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/fprobe_args_vfs.tc
> create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_vfs.tc
>
> --
> 2.31.1
>
--
Masami Hiramatsu (Google) <mhiramat@...nel.org>
Powered by blists - more mailing lists