[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20240320102229.464673-1-bhargav.r@ltts.com>
Date: Wed, 20 Mar 2024 15:52:29 +0530
From: Bhargav Raviprakash <bhargav.r@...s.com>
To: dan.carpenter@...aro.org
Cc: arnd@...db.de,
bhargav.r@...s.com,
broonie@...nel.org,
conor+dt@...nel.org,
devicetree@...r.kernel.org,
eblanc@...libre.com,
gregkh@...uxfoundation.org,
jpanis@...libre.com,
kristo@...nel.org,
krzysztof.kozlowski+dt@...aro.org,
lee@...nel.org,
lgirdwood@...il.com,
linus.walleij@...aro.org,
linux-arm-kernel@...ts.infradead.org,
linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org,
m.nirmaladevi@...s.com,
nm@...com,
robh+dt@...nel.org,
vigneshr@...com
Subject: Re: [PATCH v3 03/11] mfd: tps6594: add regmap config in match data
On Thu, 14 Mar 2024 16:30:39 +0300, Dan Carpenter wrote:
> On Fri, Mar 08, 2024 at 04:04:47PM +0530, Bhargav Raviprakash wrote:
> > +static const struct tps6594_match_data match_data[] = {
> > + [TPS6594] = {TPS6594, &tps6594_i2c_regmap_config},
> > + [TPS6593] = {TPS6593, &tps6594_i2c_regmap_config},
> > + [LP8764] = {LP8764, &tps6594_i2c_regmap_config},
> > +};
> > +
> > static const struct of_device_id tps6594_i2c_of_match_table[] = {
> > - { .compatible = "ti,tps6594-q1", .data = (void *)TPS6594, },
> > - { .compatible = "ti,tps6593-q1", .data = (void *)TPS6593, },
> > - { .compatible = "ti,lp8764-q1", .data = (void *)LP8764, },
> > + { .compatible = "ti,tps6594-q1", .data = (void *)&match_data[TPS6594], },
> > + { .compatible = "ti,tps6593-q1", .data = (void *)&match_data[TPS6593], },
> > + { .compatible = "ti,lp8764-q1", .data = (void *)&match_data[LP8764], },
>
> The casts are no longer required. Same for tps6594_spi_of_match_table.
>
> regards,
> dan carpenter
Will remove the casts in the next version. Thanks!
Regards,
Bhargav
Powered by blists - more mailing lists