linux-kernel - Re: [PATCH 2/2] dt-bindings: iio: adc: nxp,imx93-adc.yaml: Add calibration properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38637621-1611-4268-ae79-7ac93a72c5ee@linaro.org>
Date: Wed, 20 Mar 2024 11:26:31 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Andrej Picej <andrej.picej@...ik.com>, haibo.chen@....com,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org
Cc: jic23@...nel.org, lars@...afoo.de, shawnguo@...nel.org,
 s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, robh@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 upstream@...ts.phytec.de
Subject: Re: [PATCH 2/2] dt-bindings: iio: adc: nxp,imx93-adc.yaml: Add
 calibration properties

On 20/03/2024 11:04, Andrej Picej wrote:
> Document calibration properties and how to set them.

Bindings are before users.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
There is no file extension in prefixes.

> 
> Signed-off-by: Andrej Picej <andrej.picej@...ik.com>
> ---
>  .../bindings/iio/adc/nxp,imx93-adc.yaml           | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> index dacc526dc695..64958be62a6a 100644
> --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> @@ -46,6 +46,21 @@ properties:
>    "#io-channel-cells":
>      const: 1
>  
> +  nxp,calib-avg-en:
> +    description:
> +      Enable or disable averaging of calibration time.
> +    enum: [ 0, 1 ]
> +
> +  nxp,calib-nr-samples:
> +    description:
> +      Selects the number of averaging samples to be used during calibration.
> +    enum: [ 16, 32, 128, 512 ]
> +
> +  nxp,calib-t-samples:
> +    description:
> +      Specifies the sample time of calibration conversions.
> +    enum: [ 8, 16, 22, 32 ]

No, use existing, generic properties. Open other bindings for this.

Also, none of these were tested. I am not going to review such untested
code.

It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.

Best regards,
Krzysztof