linux-kernel - Re: [PATCH V3] irqchip/loongson-pch-pic: Update interrupt registration policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878r2di3ak.ffs@tglx>
Date: Wed, 20 Mar 2024 11:52:03 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Tianyang Zhang <zhangtianyang@...ngson.cn>, chenhuacai@...nel.org,
 jiaxun.yang@...goat.com
Cc: linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org, Baoqi Zhang
 <zhangbaoqi@...ngson.cn>, Biao Dong <dongbiao@...ngson.cn>, Tianyang Zhang
 <zhangtianyang@...ngson.cn>
Subject: Re: [PATCH V3] irqchip/loongson-pch-pic: Update interrupt
 registration policy

On Tue, Mar 19 2024 at 20:46, Tianyang Zhang wrote:
> From: Baoqi Zhang <zhangbaoqi@...ngson.cn>
>
> This patch remove the fixed mapping between the LS7A interrupt source

Please don't use 'This patch'. We already know that this is a patch.

See Documentation/process/

> and the HT interrupt vector, and replaced it with a dynamically
> allocated approach.

You explain the WHAT, but you really need to explain the WHY. 

> We introduce a mapping table in struct pch_pic, where each interrupt

s/We introduce/Introduce/ See documentation.

> source will allocate an index as a 'hwirq' from the table in the order
> of application and set table value as interrupt source number. This hwirq
> will be configured as its vector in the HT interrupt controller. For an
> interrupt source, the validity period of the obtained hwirq will last until
> the system reset.
>
> This will be more conducive to fully utilizing existing vectors to
> support more devices.
>
> Signed-off-by: Baoqi Zhang <zhangbaoqi@...ngson.cn>
> Signed-off-by: Biao Dong <dongbiao@...ngson.cn>
> Signed-off-by: Tianyang Zhang <zhangtianyang@...ngson.cn>

This Signed-off-by chain is wrong.

Please see Documentation/process/submitting-patches.rst

Thanks,

        tglx