linux-kernel - Re: [PATCH 2/2] KVM: s390: vsie: Use virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a25db70e-2e17-48cd-bfb3-58cddc99af7b@redhat.com>
Date: Wed, 20 Mar 2024 12:35:32 +0100
From: David Hildenbrand <david@...hat.com>
To: Nina Schoetterl-Glausch <nsg@...ux.ibm.com>,
 Alexander Gordeev <agordeev@...ux.ibm.com>,
 Claudio Imbrenda <imbrenda@...ux.ibm.com>,
 Christian Borntraeger <borntraeger@...ux.ibm.com>,
 Vasily Gorbik <gor@...ux.ibm.com>, Janosch Frank <frankja@...ux.ibm.com>,
 Heiko Carstens <hca@...ux.ibm.com>
Cc: linux-kernel@...r.kernel.org, Sven Schnelle <svens@...ux.ibm.com>,
 kvm@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH 2/2] KVM: s390: vsie: Use virt_to_phys for facility
 control block

On 19.03.24 17:44, Nina Schoetterl-Glausch wrote:
> In order for SIE to interpretively execute STFLE, it requires the real
> or absolute address of a facility-list control block.
> Before writing the location into the shadow SIE control block, convert
> it from a virtual address.
> We currently do not run into this bug because the lower 31 bits are the
> same for virtual and physical addresses.

So it's not a bug (yet) :)

But certainly the right thing to do and more future-proof.

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb