linux-kernel - Re: [PATCH v1 0/4] virt: vmgenid: Add devicetree bindings support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38aad6c0e698c8e804694276d1762d61f2068ce8.camel@infradead.org>
Date: Wed, 20 Mar 2024 13:50:43 +0000
From: David Woodhouse <dwmw2@...radead.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Sudan Landge
	 <sudanl@...zon.com>, tytso@....edu, Jason@...c4.com, robh+dt@...nel.org, 
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, 
	sathyanarayanan.kuppuswamy@...ux.intel.com, thomas.lendacky@....com, 
	dan.j.williams@...el.com, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Cc: graf@...zon.de, bchalios@...zon.es, xmarcalx@...zon.co.uk,
 ardb@...nel.org,  benh <benh@...nel.crashing.org>
Subject: Re:  [PATCH v1 0/4] virt: vmgenid: Add devicetree bindings support

On Tue, 2024-03-19 at 16:24 +0100, Krzysztof Kozlowski wrote:
> On 19/03/2024 15:32, Sudan Landge wrote:
> > This small series of patches aims to add devicetree bindings support for
> > the Virtual Machine Generation ID (vmgenid) driver.
> > 
> > Virtual Machine Generation ID driver was introduced in commit af6b54e2b5ba
> > ("virt: vmgenid: notify RNG of VM fork and supply generation ID") as an
> > ACPI only device.
> > We would like to extend vmgenid to support devicetree bindings because:
> > 1. A device should not be defined as an ACPI or DT only device.
> 
> Virtual stuff is not a device, so your first assumption or rationale is
> not correct.
> 
> Virtual stuff can be ACPI only, because DT is not for Virtual stuff.

I strongly disagree with this.

Discovering things is what the device-tree is *for*.

We don't want to add extra complexity and overhead on both host and
guest side to make things discoverable in a *less* efficient way.

The device-tree isn't just a last-resort for when we can't possibly do
things differently in a discoverable way. The device-tree is a first-
class citizen and perfectly valid choice as a way to discover things.

We shouldn't be forcing people to turn things into PCI devices just to
avoid adding DT bindings for them.

And we *certainly* shouldn't be directing people towards all the
awfulness of ACPI, and in-kernel bytecode interpreters, and all that
horridness, just because we don't want to use DT to... describe things.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)