linux-kernel - Re: [PATCH net v2] nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <d09d7505-7421-4975-a73d-3253d32c4db1@app.fastmail.com>
Date: Wed, 20 Mar 2024 10:11:49 -0400
From: "Jeremy Cline" <jeremy@...ine.org>
To: "Ryosuke Yasuoka" <ryasuoka@...hat.com>,
 "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>,
 "David S . Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>,
 "Paolo Abeni" <pabeni@...hat.com>, horms@...nel.org
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, syoshida@...hat.com,
 syzbot+7ea9413ea6749baf5574@...kaller.appspotmail.com,
 syzbot+29b5ca705d2e0f4a44d2@...kaller.appspotmail.com
Subject: Re: [PATCH net v2] nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet

On Tue, Mar 19, 2024, at 8:54 PM, Ryosuke Yasuoka wrote:
> syzbot reported the following uninit-value access issue [1][2]:
>
> nci_rx_work() parses and processes received packet. When the payload
> length is zero, each message type handler reads uninitialized payload
> and KMSAN detects this issue. The receipt of a packet with a zero-size
> payload is considered unexpected, and therefore, such packets should be
> silently discarded.
>
> This patch resolved this issue by checking payload size before calling
> each message type handler codes.
>
> Fixes: 6a2968aaf50c ("NFC: basic NCI protocol implementation")
> Reported-and-tested-by: syzbot+7ea9413ea6749baf5574@...kaller.appspotmail.com
> Reported-and-tested-by: syzbot+29b5ca705d2e0f4a44d2@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=7ea9413ea6749baf5574 [1]
> Closes: https://syzkaller.appspot.com/bug?extid=29b5ca705d2e0f4a44d2 [2]
> Signed-off-by: Ryosuke Yasuoka <ryasuoka@...hat.com>
> ---

For what it's worth,

Reviewed-by: Jeremy Cline <jeremy@...ine.org>