linux-kernel - Re: [PATCH v3 1/2] dt-bindings: hwmon: pmbus: adp1050: add bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <473a833c-b166-4002-823c-a71e5aaa784a@linaro.org>
Date: Wed, 20 Mar 2024 15:19:35 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: "Sabau, Radu bogdan" <Radu.Sabau@...log.com>,
 Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
 Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>,
 Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>,
 "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
 "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: pmbus: adp1050: add bindings

On 20/03/2024 14:05, Sabau, Radu bogdan wrote:

>> +examples:
>> +  - |
>> +    i2c {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +        clock-frequency = <100000>;
>> +
>> +        hwmon@70 {
>> +            compatible = "adi,adp1050";
>> +            reg = <0x70>;
>> +            vcc-supply = <&vcc>;
>> +        };
>> +    };
>> +...
> 
> Results of bindings testing :
> 

Yeah... please do not send patches which contain knowingly wrong code.
Code is wrong if you perform testing and result is some sort of FAILURE,
build error, warning message, static checker/linter warning message or
error.

If something is not clear, ask via email or IRC, but sending code which
does not work could cause wasted reviewer's effort.

About your warning, please start your bindings from example-schema or
latest reviewed bindings.

Best regards,
Krzysztof