linux-kernel - Re: [PATCH] wifi: ath11k: allocate dummy net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd9a0575-c7e0-4443-9417-7a998e1ae123@quicinc.com>
Date: Wed, 20 Mar 2024 08:06:29 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Kalle Valo <kvalo@...nel.org>, Breno Leitao <leitao@...ian.org>
CC: Jeff Johnson <jjohnson@...nel.org>, <kuba@...nel.org>,
        <keescook@...omium.org>,
        "open list:NETWORKING DRIVERS (WIRELESS)"
	<linux-wireless@...r.kernel.org>,
        "open list:QUALCOMM ATHEROS ATH11K WIRELESS
 DRIVER" <ath11k@...ts.infradead.org>,
        open list
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wifi: ath11k: allocate dummy net_device dynamically

On 3/20/2024 7:32 AM, Kalle Valo wrote:
> Breno Leitao <leitao@...ian.org> writes:
> 
>> Embedding net_device into structures prohibits the usage of flexible
>> arrays in the net_device structure. For more details, see the discussion
>> at [1].
>>
>> Un-embed the net_device from struct ath11k_ext_irq_grp by converting it
>> into a pointer. Then use the leverage alloc_netdev() to allocate the
>> net_device object at ath11k_ahb_config_ext_irq() for ahb, and
>> ath11k_pcic_ext_irq_config() for pcic.
>>
>>  The free of the device occurs at ath11k_ahb_free_ext_irq() for the ahb
>> case, and ath11k_pcic_free_ext_irq() for the pcic case.
>>
>> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
>>
>> Signed-off-by: Breno Leitao <leitao@...ian.org>
> 
> This crashes on my nuc x86 test box with WCN6855 hw2.0 when running
> rmmod, stacktrace below. I used tag ath-202403201010 from my ath.git
> tree as the baseline. Sorry that I'm not able to debug this further
> right now.

It seems to maintain the logic of the original that we should not use
alloc_netdev() and free_netdev() but instead should just use kmalloc()/kfree().