linux-kernel - Re: [PATCH] ath10k: allocate dummy net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wmpwaprz.fsf@kernel.org>
Date: Wed, 20 Mar 2024 17:25:52 +0200
From: Kalle Valo <kvalo@...nel.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: Breno Leitao <leitao@...ian.org>,  Jeff Johnson <jjohnson@...nel.org>,
  <kuba@...nel.org>,  <keescook@...omium.org>,  "open list:NETWORKING
 DRIVERS (WIRELESS)" <linux-wireless@...r.kernel.org>,  "open list:QUALCOMM
 ATHEROS ATH10K WIRELESS DRIVER" <ath10k@...ts.infradead.org>,  open list
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ath10k: allocate dummy net_device dynamically

Jeff Johnson <quic_jjohnson@...cinc.com> writes:

> On 3/19/2024 3:47 AM, Breno Leitao wrote:
>> Embedding net_device into structures prohibits the usage of flexible
>> arrays in the net_device structure. For more details, see the discussion
>> at [1].
>> 
>> Un-embed the net_device from struct ath10k by converting it
>> into a pointer. Then use the leverage alloc_netdev() to allocate the
>> net_device object at ath10k_core_create(). The free of the device occurs
>> at ath10k_core_destroy().
>> 
>> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
>> 
>> Signed-off-by: Breno Leitao <leitao@...ian.org>
>
> NAK this based upon the ath11k patch results.
>
> As suggested there we should just use kmalloc/kfree to match the existing logic.

BTW if the patch is not tested on a real device then it's good to
document that in the commit message with "Compile tested only" or
similar.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches