[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <05dcb857-706e-4674-8221-7d0209e6c1fb@linaro.org>
Date: Wed, 20 Mar 2024 15:26:28 +0000
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Depeng Shao <quic_depengs@...cinc.com>, rfoss@...nel.org,
todor.too@...il.com, andersson@...nel.org, konrad.dybcio@...aro.org,
mchehab@...nel.org, quic_yon@...cinc.com
Cc: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2 4/8] media: qcom: camss: Add new params for csid_device
On 20/03/2024 14:11, Depeng Shao wrote:
> CSID gen3 has a new register block which is named as
> CSID top, it controls the output of CSID, since the
> CSID can connect to SFE or original VFE in CSID gen3.
> The register update is moved to CSID from VFE in CSID
> gen3.
> So, adding top_base and reg_update variables in csid
> device structure for CSID gen3.
You need to define three letter acronyms (TLAs) - within reason - the
first time you use them.
There is no concept of an "SFE" upstream - please define what the SFE is
in the commit log "to the Sensor Front End (SFE)" then you can refer
back to the acronym liberally.
---
bod
Powered by blists - more mailing lists