[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <69364c99-9b99-4727-812b-209bb82254a7@quicinc.com>
Date: Wed, 20 Mar 2024 22:38:29 +0530
From: Odelu Kukatla <quic_okukatla@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Bjorn Andersson
<andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
"Georgi
Djakov" <djakov@...nel.org>, Rob Herring <robh@...nel.org>,
"Krzysztof
Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley
<conor+dt@...nel.org>
CC: Kees Cook <keescook@...omium.org>, <cros-qcom-dts-watchers@...omium.org>,
"Gustavo A . R . Silva" <gustavoars@...nel.org>,
<linux-arm-msm@...r.kernel.org>, <linux-pm@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-hardening@...r.kernel.org>, <quic_rlaggysh@...cinc.com>,
<quic_mdtipton@...cinc.com>
Subject: Re: [PATCH v3 3/4] dt-bindings: interconnect: add clock property to
enable QOS on SC7280
On 3/6/2024 1:56 PM, Krzysztof Kozlowski wrote:
> On 06/03/2024 08:30, Odelu Kukatla wrote:
>> Added clock property to enable clocks required for accessing
>> qos registers.
>>
>> Signed-off-by: Odelu Kukatla <quic_okukatla@...cinc.com>
>> ---
>> .../interconnect/qcom,sc7280-rpmh.yaml | 49 +++++++++++++++++++
>> 1 file changed, 49 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml
>> index b135597d9489..758a6e924037 100644
>> --- a/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml
>> +++ b/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml
>> @@ -53,10 +53,50 @@ allOf:
>> required:
>> - reg
>>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sc7280-aggre1-noc
>> + then:
>> + properties:
>> + clocks:
>
> All properties must be defined in top-level.
>
I will address this in v4, "clocks" property could be optional.
>> + items:
>> + - description: aggre UFS PHY AXI clock
>> + - description: aggre USB3 PRIM AXI clock
>> +
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sc7280-aggre2-noc
>> + then:
>> + properties:
>> + clocks:
>> + items:
>> + - description: RPMH CC IPA clock
>> +
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sc7280-aggre1-noc
>> + - qcom,sc7280-aggre2-noc
>> + then:
>> + required:
>> + - clocks
>
> That's an ABI break without reason. This is a stable and already used
> platform, so clear NAK.
>
> Best regards,
> Krzysztof
>
Thanks,
Odelu
Powered by blists - more mailing lists