[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<BYAPR02MB59589FFEAB8BB9578A61B39083322@BYAPR02MB5958.namprd02.prod.outlook.com>
Date: Thu, 21 Mar 2024 18:49:12 +0000
From: Selvamani Rajagopal <Selvamani.Rajagopal@...emi.com>
To: Parthiban Veerasooran <Parthiban.Veerasooran@...rochip.com>,
"davem@...emloft.net" <davem@...emloft.net>,
"edumazet@...gle.com"
<edumazet@...gle.com>,
"kuba@...nel.org" <kuba@...nel.org>,
"pabeni@...hat.com" <pabeni@...hat.com>,
"horms@...nel.org"
<horms@...nel.org>,
"saeedm@...dia.com" <saeedm@...dia.com>,
"anthony.l.nguyen@...el.com" <anthony.l.nguyen@...el.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"andrew@...n.ch" <andrew@...n.ch>, "corbet@....net" <corbet@....net>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"robh+dt@...nel.org"
<robh+dt@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"conor+dt@...nel.org"
<conor+dt@...nel.org>,
"devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>,
"horatiu.vultur@...rochip.com"
<horatiu.vultur@...rochip.com>,
"ruanjinjie@...wei.com"
<ruanjinjie@...wei.com>,
"steen.hegelund@...rochip.com"
<steen.hegelund@...rochip.com>,
"vladimir.oltean@....com"
<vladimir.oltean@....com>
CC: "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
"Thorsten.Kummermehr@...rochip.com" <Thorsten.Kummermehr@...rochip.com>,
Piergiorgio Beruto <Pier.Beruto@...emi.com>,
"Nicolas.Ferre@...rochip.com"
<Nicolas.Ferre@...rochip.com>,
"benjamin.bigler@...nformulastudent.ch"
<benjamin.bigler@...nformulastudent.ch>
Subject: RE: [PATCH net-next v3 06/12] net: ethernet: oa_tc6: implement
internal PHY initialization
> +static int oa_tc6_mdiobus_register(struct oa_tc6 *tc6) {
> + int ret;
> +
> + tc6->mdiobus = mdiobus_alloc();
> + if (!tc6->mdiobus) {
> + netdev_err(tc6->netdev, "MDIO bus alloc failed\n");
> + return -ENODEV;
> + }
Shouldn't it be appropriate to return -ENOMEM here?
> +
> + tc6->mdiobus->priv = tc6;
> + tc6->mdiobus->read = oa_tc6_mdiobus_direct_read;
> + tc6->mdiobus->write = oa_tc6_mdiobus_direct_write;
> + tc6->mdiobus->name = "oa-tc6-mdiobus";
> + tc6->mdiobus->parent = tc6->dev;
> +
Powered by blists - more mailing lists