linux-kernel - Re: [PATCH] drm/amdgpu: fix function implicit declaration error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_NbOxav2U-hK8PGnsSymqKn_xjuxGtStjuHzWu_PjfPmA@mail.gmail.com>
Date: Thu, 21 Mar 2024 15:45:50 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Sunil Khatri <sunil.khatri@....com>
Cc: Alex Deucher <alexander.deucher@....com>, 
	Christian König <christian.koenig@....com>, 
	Shashank Sharma <shashank.sharma@....com>, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	Hawking Zhang <Hawking.Zhang@....com>, Felix Kuehling <Felix.Kuehling@....com>, 
	Lijo Lazar <lijo.lazar@....com>
Subject: Re: [PATCH] drm/amdgpu: fix function implicit declaration error

Acked-by: Alex Deucher <alexander.deucher@....com>

On Thu, Mar 21, 2024 at 2:14 PM Sunil Khatri <sunil.khatri@....com> wrote:
>
> when CONFIG_DEV_COREDUMP is not defined in that case
> when amdgpu_coredump() is called it does not find it's
> definition and the build fails.
>
> This happens as the header is defined without the
> CONFIG_DEV_COREDUMP ifdef and due to which header isn't
> enabled.
>
> Pulling the header out of such ifdef so in both the
> cases the build does not fail.
>
> Signed-off-by: Sunil Khatri <sunil.khatri@....com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 95028f57cb56..f771b2042a43 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -74,10 +74,7 @@
>  #include "amdgpu_fru_eeprom.h"
>  #include "amdgpu_reset.h"
>  #include "amdgpu_virt.h"
> -
> -#ifdef CONFIG_DEV_COREDUMP
>  #include "amdgpu_dev_coredump.h"
> -#endif
>
>  #include <linux/suspend.h>
>  #include <drm/task_barrier.h>
> --
> 2.34.1
>