linux-kernel - Re: [PATCH] i2c: i801: Fix a refactoring that broke a touchpad on Lenovo P1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 21 Mar 2024 21:41:59 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Maxim Levitsky <mlevitsk@...hat.com>
Cc: linux-kernel@...r.kernel.org, Jean Delvare <jdelvare@...e.com>, 
	Heiner Kallweit <hkallweit1@...il.com>, linux-i2c@...r.kernel.org
Subject: Re: [PATCH] i2c: i801: Fix a refactoring that broke a touchpad on
 Lenovo P1

Hi Maxim,

On Thu, Mar 21, 2024 at 10:19:19AM -0400, Maxim Levitsky wrote:
> Commit 857cc04cdf50 ("i2c: i801: Add helper i801_get_block_len")
> introduced a slight functional change: the status variable is now
> overwritten with the length of an SMBUS tranasaction,
> even in case of success.
> 
> This breaks the touchpad on at least my Lenovo P1:
> 
> rmi4_physical rmi4-00: Read PDT entry at 0x00e9 failed, code: -6.
> rmi4_physical rmi4-00: RMI initial reset failed! Continuing in spite of this.
> rmi4_physical rmi4-00: Read PDT entry at 0x00e9 failed, code: -6.
> rmi4_physical rmi4-00: IRQ counting failed with code -6.
> 
> Fixes: 857cc04cdf50 ("i2c: i801: Add helper i801_get_block_len")
> 

next time please drop this blank line here.

Applied to i2c/i2c-host-fixes on

git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git

Thank you,
Andi

Patches applied
===============
[1/1] i2c: i801: Fix a refactoring that broke a touchpad on Lenovo P1
      commit: a5894bc48f64caa86dbea1744d067c925303c5fc