linux-kernel - RE: [PATCH V2] gpiolib: use dev_err() when gpiod_configure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 21 Mar 2024 05:40:09 +0000
From: Peng Fan <peng.fan@....com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
CC: "Peng Fan (OSS)" <peng.fan@....nxp.com>, "linus.walleij@...aro.org"
	<linus.walleij@...aro.org>, "brgl@...ev.pl" <brgl@...ev.pl>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V2] gpiolib: use dev_err() when gpiod_configure_flags
 failed

> Subject: Re: [PATCH V2] gpiolib: use dev_err() when gpiod_configure_flags
> failed
> 
> On Wed, Mar 20, 2024 at 11:07:40AM +0000, Peng Fan wrote:
> > > On Wed, Mar 20, 2024 at 9:25 AM Peng Fan (OSS)
> > > <peng.fan@....nxp.com>
> > > wrote:
> 
> ...
> 
> > > > When gpio-ranges property was missed to be added in the gpio node,
> > > > using dev_err() to show an error message will helping to locate
> > > > issues easier.
> > >
> > > I'm not convinced, so not my call to approve / reject, but see a remark
> below.
> >
> > You mean dev_err not help or else?
> 
> Moving it to error level.
> Usually developers enable CONFIG_DEBUG_GPIO for these messages to
> appear.

But this is a error log. Let's leave this to gpio maintainers.

> 
> ...
> 
> > > >         ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
> > > >         if (ret < 0) {
> > > > -               dev_dbg(consumer, "setup of GPIO %s failed\n", con_id);
> > > > +               dev_err(consumer, "setup of GPIO %s failed: %d\n",
> > > > + con_id, ret);
> > > >                 gpiod_put(desc);
> > > >                 return ERR_PTR(ret);
> > >
> > > While at it, can you move it to be after the gpiod_put()?
> >
> > Does it matter?
> 
> Yes, the system gives resource back as soon as possible.

Got it.

Thanks,
Peng.

> 
> --
> With Best Regards,
> Andy Shevchenko
>