linux-kernel - Re: [PATCH] reset: gpio: Fix missing gpiolib dependency for GPIO reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c5efec9-cb29-4226-8701-2917ce3c2876@linaro.org>
Date: Thu, 21 Mar 2024 08:18:36 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Mark Brown <broonie@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reset: gpio: Fix missing gpiolib dependency for GPIO
 reset controller

On 20/03/2024 20:59, Mark Brown wrote:
> The GPIO reset controller uses gpiolib but there is no Kconfig
> dependency reflecting this fact, add one.
> 
> With the addition of the controller to the arm64 defconfig this is
> causing build breaks for arm64 virtconfig in -next:
> 
> aarch64-linux-gnu-ld: drivers/reset/core.o: in function `__reset_add_reset_gpio_lookup':
> /build/stage/linux/drivers/reset/core.c:861:(.text+0xccc): undefined reference to `gpio_device_find_by_fwnode'
> 

Lack of dependency was intentional: because there is no dependency.
GPIOLIB is optional. Because of that I added few stubs for missing
GPIOLIB functions, but I missed this stub here.

I propose to add gpio_device_find_by_fwnode() stub for !GPIOLIB case,
instead of adding dependency.

Best regards,
Krzysztof