linux-kernel - Re: [PATCH v1] thermal: devfreq_cooling: Fix perf state when calculate dfc res

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Thu, 21 Mar 2024 08:44:46 +0000
From: Lukasz Luba <lukasz.luba@....com>
To: 张烨 <ye.zhang@...k-chips.com>
Cc: "tao.huang" <tao.huang@...k-chips.com>, heiko <heiko@...ech.de>,
 "rui.zhang" <rui.zhang@...el.com>, "finley.xiao"
 <finley.xiao@...k-chips.com>,
 linux-rockchip <linux-rockchip@...ts.infradead.org>,
 linux-pm <linux-pm@...r.kernel.org>,
 linux-kernel <linux-kernel@...r.kernel.org>,
 "daniel.lezcano" <daniel.lezcano@...aro.org>, rafael <rafael@...nel.org>
Subject: Re: [PATCH v1] thermal: devfreq_cooling: Fix perf state when
 calculate dfc res_util



On 3/21/24 08:37, 张烨 wrote:
> 
> Hi Lukasz,
> 
> Regarding your question about how I triggered the issue andifI have a 
> driver that provides the get_real_power() callback:
> 
> I encountered thisissue whilecalculating the GPU power consumption onthe 
> Rockchip RK3399 platform. The GPU model isMali T860, which isan ARM 
> Midgard GPU. The driver version isr18p0-01rel0, andit provides the 
> get_real_power() callback.Best regards, Ye Zhang

Yes that would trigger the issue. Thank you Ye for
sharing that.

BTW, I also use RK3399 for my mainline kernel development.
I use the Rock Pi 4SE with the mainline GPU driver
'panfrost'. That GPU driver doesn't support the get_real_power()
callback, but maybe it would be worth to add it...

Please send the v2 and I will add my reviewed-by tag for it.

Regards,
Lukasz