linux-kernel - Re: [PATCH] ata: ahci_ceva: return of_property_read_u8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 21 Mar 2024 10:22:00 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
 linux-ide@...r.kernel.org, kernel-janitors@...r.kernel.org, git@....com,
 Damien Le Moal <dlemoal@...nel.org>, Niklas Cassel <cassel@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Jens Axboe <axboe@...nel.dk>,
 Michal Simek <michal.simek@....com>, Peter Zijlstra <peterz@...radead.org>,
 Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH] ata: ahci_ceva: return of_property_read_u8_array() error
 code

> In the ahci_ceva_probe() error path instead of returning -EINVAL for all
> of_property_read_u8_array() failure types return the actual error code.
> It removes the redundant -EINVAL assignment at multiple places and
> improves the error handling path.

A) Would a change description be more desirable with a corresponding imperative wording?

   See also:
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.8#n94


B) Can it be helpful to specify the hint “in ceva_ahci_probe()” at the end
   of the patch subject?


C) How do you think about to extend the application of scope-based resource management here?

   See also:
   Article by Jonathan Corbet
   2023-06-15
   https://lwn.net/Articles/934679/


Regards,
Markus