linux-kernel - Re: [PATCH bpf-next v2] arm64: bpf: fix 32bit unconditional bswap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 21 Mar 2024 11:00:26 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Artem Savkov <asavkov@...hat.com>
Cc: xukuohai@...wei.com, xi.wang@...il.com, ast@...nel.org,
 daniel@...earbox.net, andrii@...nel.org, bpf@...r.kernel.org,
 netdev@...r.kernel.org, catalin.marinas@....com,
 linux-kernel@...r.kernel.org, puranjay12@...il.com
Subject: Re: [PATCH bpf-next v2] arm64: bpf: fix 32bit unconditional bswap

Hello:

This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@...nel.org>:

On Thu, 21 Mar 2024 09:18:09 +0100 you wrote:
> In case when is64 == 1 in emit(A64_REV32(is64, dst, dst), ctx) the
> generated insn reverses byte order for both high and low 32-bit words,
> resuling in an incorrect swap as indicated by the jit test:
> 
> [ 9757.262607] test_bpf: #312 BSWAP 16: 0x0123456789abcdef -> 0xefcd jited:1 8 PASS
> [ 9757.264435] test_bpf: #313 BSWAP 32: 0x0123456789abcdef -> 0xefcdab89 jited:1 ret 1460850314 != -271733879 (0x5712ce8a != 0xefcdab89)FAIL (1 times)
> [ 9757.266260] test_bpf: #314 BSWAP 64: 0x0123456789abcdef -> 0x67452301 jited:1 8 PASS
> [ 9757.268000] test_bpf: #315 BSWAP 64: 0x0123456789abcdef >> 32 -> 0xefcdab89 jited:1 8 PASS
> [ 9757.269686] test_bpf: #316 BSWAP 16: 0xfedcba9876543210 -> 0x1032 jited:1 8 PASS
> [ 9757.271380] test_bpf: #317 BSWAP 32: 0xfedcba9876543210 -> 0x10325476 jited:1 ret -1460850316 != 271733878 (0xa8ed3174 != 0x10325476)FAIL (1 times)
> [ 9757.273022] test_bpf: #318 BSWAP 64: 0xfedcba9876543210 -> 0x98badcfe jited:1 7 PASS
> [ 9757.274721] test_bpf: #319 BSWAP 64: 0xfedcba9876543210 >> 32 -> 0x10325476 jited:1 9 PASS
> 
> [...]

Here is the summary with links:
  - [bpf-next,v2] arm64: bpf: fix 32bit unconditional bswap
    https://git.kernel.org/bpf/bpf/c/a51cd6bf8e10

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html