linux-kernel - 回复: [v1] staging: media: starfive: Renamed capture_raw to capture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 21 Mar 2024 12:17:24 +0000
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: Hans Verkuil <hverkuil-cisco@...all.nl>, Mauro Carvalho Chehab
	<mchehab@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: Laurent Pinchart <laurent.pinchart@...asonboard.com>, Jack Zhu
	<jack.zhu@...rfivetech.com>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-staging@...ts.linux.dev"
	<linux-staging@...ts.linux.dev>
Subject:
 回复: [v1] staging: media: starfive: Renamed capture_raw to capture_dump

Hi, Hans

Thanks for your comments.

> On 01/03/2024 8:00 am, Changhuang Liang wrote:
> > The pixel formats captured by the capture_raw video device depends on
> > what pixel formats come from the source device. It is actually dump
> > the source device data. So renamed it to capture_dump.
> 
> I don't think 'dump' is a great name. I think what you really want to say is
> 'unprocessed'. And usually that is indeed called 'raw capture'.
> 

StarFive JH7110 SoC also supports the output of the raw format data from ISP port, see:

https://lore.kernel.org/all/20240306093334.9321-1-changhuang.liang@starfivetech.com/

So I think it is better to call the ISP output port "capture_raw".

On the other hand, Old "capture_raw" video devices can also support YUV color space, 
mainly depending on the camera output format. There may be a confusion called it "capture_raw".

Regards,
Changhuang