linux-kernel - Re: [PATCH net v4] net: txgbe: fix i2c dev name cannot match clkdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <61624f55-2f1f-4cb3-8845-0dc3988a849d@gmail.com>
Date: Thu, 21 Mar 2024 06:06:39 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Duanqiang Wen <duanqiangwen@...-swift.com>, netdev@...r.kernel.org,
 jiawenwu@...stnetic.com, mengyuanlou@...-swift.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 maciej.fijalkowski@...el.com, andrew@...n.ch, wangxiongfeng2@...wei.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v4] net: txgbe: fix i2c dev name cannot match clkdev



On 3/20/2024 10:47 PM, Duanqiang Wen wrote:
> txgbe clkdev shortened clk_name, so i2c_dev info_name
> also need to shorten. Otherwise, i2c_dev cannot initialize
> clock. And had "i2c_dw" string in a define.
> 
> Fixes: e30cef001da2 ("net: txgbe: fix clk_name exceed MAX_DEV_ID limits")
> Signed-off-by: Duanqiang Wen <duanqiangwen@...-swift.com>

When Jiri suggested to use a define, I did not read it as meaning a 
define local within the driver, but rather a define that would span 
beyond you driver that would match what is expected to be used by 
drivers/i2c/busses/i2c-designware-pcidrv.c.

As a matter of fact, there are quite a few drivers that expect to use 
this driver name:

git grep i2c_designware *
drivers/i2c/busses/i2c-designware-pcidrv.c:MODULE_ALIAS("i2c_designware-pci");
drivers/i2c/busses/i2c-designware-platdrv.c:MODULE_ALIAS("platform:i2c_designware");
drivers/i2c/busses/i2c-designware-platdrv.c:            .name   = 
"i2c_designware",
drivers/mfd/intel-lpss.c:       .name = "i2c_designware",
drivers/mfd/intel_quark_i2c_gpio.c:#define 
INTEL_QUARK_I2C_CONTROLLER_CLK "i2c_designware.0"
drivers/mfd/intel_quark_i2c_gpio.c:             .name = "i2c_designware",
drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c: snprintf(clk_name, 
sizeof(clk_name), "i2c_designware.%d",
drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c: info.name = 
"i2c_designware";

so they should all be covered by using a define under 
include/linux/i2c-designware.h.

--
Florian