linux-kernel - Re: [PATCH 09/10] mm: page_isolation: prepare for hygienic freelists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202403212118.ye7lcKjD-lkp@intel.com>
Date: Thu, 21 Mar 2024 21:13:57 +0800
From: kernel test robot <lkp@...el.com>
To: Johannes Weiner <hannes@...xchg.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc: oe-kbuild-all@...ts.linux.dev,
	Linux Memory Management List <linux-mm@...ck.org>,
	Vlastimil Babka <vbabka@...e.cz>, Mel Gorman <mgorman@...e.de>,
	Zi Yan <ziy@...dia.com>, "Huang, Ying" <ying.huang@...el.com>,
	David Hildenbrand <david@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/10] mm: page_isolation: prepare for hygienic freelists

Hi Johannes,

kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Johannes-Weiner/mm-page_alloc-remove-pcppage-migratetype-caching/20240321-020814
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20240320180429.678181-10-hannes%40cmpxchg.org
patch subject: [PATCH 09/10] mm: page_isolation: prepare for hygienic freelists
config: i386-randconfig-003-20240321 (https://download.01.org/0day-ci/archive/20240321/202403212118.ye7lcKjD-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240321/202403212118.ye7lcKjD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403212118.ye7lcKjD-lkp@intel.com/

All warnings (new ones prefixed by >>):

   mm/page_alloc.c: In function 'move_freepages_block_isolate':
>> mm/page_alloc.c:688:17: warning: array subscript 11 is above array bounds of 'struct free_area[11]' [-Warray-bounds]
     688 |  zone->free_area[order].nr_free--;
         |  ~~~~~~~~~~~~~~~^~~~~~~
>> mm/page_alloc.c:688:17: warning: array subscript 11 is above array bounds of 'struct free_area[11]' [-Warray-bounds]


vim +688 mm/page_alloc.c

6ab0136310961eb Alexander Duyck 2020-04-06  677  
6ab0136310961eb Alexander Duyck 2020-04-06  678  static inline void del_page_from_free_list(struct page *page, struct zone *zone,
6ab0136310961eb Alexander Duyck 2020-04-06  679  					   unsigned int order)
6ab0136310961eb Alexander Duyck 2020-04-06  680  {
36e66c554b5c6a9 Alexander Duyck 2020-04-06  681  	/* clear reported state and update reported page count */
36e66c554b5c6a9 Alexander Duyck 2020-04-06  682  	if (page_reported(page))
36e66c554b5c6a9 Alexander Duyck 2020-04-06  683  		__ClearPageReported(page);
36e66c554b5c6a9 Alexander Duyck 2020-04-06  684  
bf75f200569dd05 Mel Gorman      2022-06-24  685  	list_del(&page->buddy_list);
6ab0136310961eb Alexander Duyck 2020-04-06  686  	__ClearPageBuddy(page);
6ab0136310961eb Alexander Duyck 2020-04-06  687  	set_page_private(page, 0);
6ab0136310961eb Alexander Duyck 2020-04-06 @688  	zone->free_area[order].nr_free--;
6ab0136310961eb Alexander Duyck 2020-04-06  689  }
6ab0136310961eb Alexander Duyck 2020-04-06  690  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki