linux-kernel - Re: [PATCH 1/2] dt-bindings: leds: add LED_FUNCTION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240321135502.GA1637678-robh@kernel.org>
Date: Thu, 21 Mar 2024 08:55:02 -0500
From: Rob Herring <robh@...nel.org>
To: INAGAKI Hiroshi <musashino.open@...il.com>
Cc: pavel@....cz, lee@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	conor+dt@...nel.org, linux-leds@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Hauke Mehrtens <hauke@...ke-m.de>
Subject: Re: [PATCH 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for
 mobile network

On Wed, Mar 20, 2024 at 09:43:16PM +0900, INAGAKI Hiroshi wrote:
> Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network
> connection.
> As an example, "Mobile" LEDs on IIJ SA-W2 indicate status (no signal,
> too low, low, good) of mobile network connection via dongle connected
> to USB port.
> 
> Suggested-by: Hauke Mehrtens <hauke@...ke-m.de>
> Signed-off-by: INAGAKI Hiroshi <musashino.open@...il.com>
> ---
>  include/dt-bindings/leds/common.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> index ecea167930d9..d4b8498bde7f 100644
> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -91,6 +91,7 @@
>  #define LED_FUNCTION_LAN "lan"
>  #define LED_FUNCTION_MAIL "mail"
>  #define LED_FUNCTION_MTD "mtd"
> +#define LED_FUNCTION_MOBILE "mobile"

Why doesn't "wan" work?

>  #define LED_FUNCTION_PANIC "panic"
>  #define LED_FUNCTION_PROGRAMMING "programming"
>  #define LED_FUNCTION_RX "rx"
> -- 
> 2.25.1
>