linux-kernel - RE: [PATCH v6 1/6] cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 21 Mar 2024 02:25:41 +0000
From: "Yuan, Perry" <Perry.Yuan@....com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
CC: "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>, "Limonciello,
 Mario" <Mario.Limonciello@....com>, "viresh.kumar@...aro.org"
	<viresh.kumar@...aro.org>, "Huang, Ray" <Ray.Huang@....com>, "Shenoy, Gautham
 Ranjal" <gautham.shenoy@....com>, "Petkov, Borislav"
	<Borislav.Petkov@....com>, "Deucher, Alexander" <Alexander.Deucher@....com>,
	"Huang, Shimmer" <Shimmer.Huang@....com>, "oleksandr@...alenko.name"
	<oleksandr@...alenko.name>, "Du, Xiaojian" <Xiaojian.Du@....com>, "Meng, Li
 (Jassmine)" <Li.Meng@....com>, "linux-pm@...r.kernel.org"
	<linux-pm@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6 1/6] cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into
 msr-index.h

[AMD Official Use Only - General]

Hi Rafael,

> -----Original Message-----
> From: Rafael J. Wysocki <rafael@...nel.org>
> Sent: Monday, March 18, 2024 8:43 PM
> To: Yuan, Perry <Perry.Yuan@....com>
> Cc: rafael.j.wysocki@...el.com; Limonciello, Mario
> <Mario.Limonciello@....com>; viresh.kumar@...aro.org; Huang, Ray
> <Ray.Huang@....com>; Shenoy, Gautham Ranjal
> <gautham.shenoy@....com>; Petkov, Borislav <Borislav.Petkov@....com>;
> Deucher, Alexander <Alexander.Deucher@....com>; Huang, Shimmer
> <Shimmer.Huang@....com>; oleksandr@...alenko.name; Du, Xiaojian
> <Xiaojian.Du@....com>; Meng, Li (Jassmine) <Li.Meng@....com>; linux-
> pm@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v6 1/6] cpufreq: acpi: move
> MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h
>
> On Mon, Mar 18, 2024 at 11:12 AM Perry Yuan <perry.yuan@....com>
> wrote:
> >
> > There are some other drivers also need to use the
> > MSR_K7_HWCR_CPB_DIS_BIT for CPB control bit, so it makes sense to move
> > the definition to a common header file to allow other driver to use it.
> >
> > No intentional functional impact.
> >
> > Suggested-by: Gautham Ranjal Shenoy <gautham.shenoy@....com>
> > Signed-off-by: Perry Yuan <perry.yuan@....com>
>
> This change is fine with me, so
>
> Acked-by: Rafael J. Wysocki <rafael@...nel.org>

Thank you help to ack the change,
Will pick tag in next version.

Perry.

>
> > ---
> >  arch/x86/include/asm/msr-index.h | 2 ++
> >  drivers/cpufreq/acpi-cpufreq.c   | 2 --
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/x86/include/asm/msr-index.h
> > b/arch/x86/include/asm/msr-index.h
> > index 05956bd8bacf..41503647192e 100644
> > --- a/arch/x86/include/asm/msr-index.h
> > +++ b/arch/x86/include/asm/msr-index.h
> > @@ -775,6 +775,8 @@
> >  #define MSR_K7_HWCR_IRPERF_EN
> BIT_ULL(MSR_K7_HWCR_IRPERF_EN_BIT)
> >  #define MSR_K7_FID_VID_CTL             0xc0010041
> >  #define MSR_K7_FID_VID_STATUS          0xc0010042
> > +#define MSR_K7_HWCR_CPB_DIS_BIT                25
> > +#define MSR_K7_HWCR_CPB_DIS
> BIT_ULL(MSR_K7_HWCR_CPB_DIS_BIT)
> >
> >  /* K6 MSRs */
> >  #define MSR_K6_WHCR                    0xc0000082
> > diff --git a/drivers/cpufreq/acpi-cpufreq.c
> > b/drivers/cpufreq/acpi-cpufreq.c index 37f1cdf46d29..2fc82831bddd
> > 100644
> > --- a/drivers/cpufreq/acpi-cpufreq.c
> > +++ b/drivers/cpufreq/acpi-cpufreq.c
> > @@ -50,8 +50,6 @@ enum {
> >  #define AMD_MSR_RANGE          (0x7)
> >  #define HYGON_MSR_RANGE                (0x7)
> >
> > -#define MSR_K7_HWCR_CPB_DIS    (1ULL << 25)
> > -
> >  struct acpi_cpufreq_data {
> >         unsigned int resume;
> >         unsigned int cpu_feature;
> > --
> > 2.34.1
> >
> >