linux-kernel - Re: [PATCH net-next v5 13/17] net: pse-pd: Use regulator framework within PSE framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZfxjosqPMo0ECBmx@pengutronix.de>
Date: Thu, 21 Mar 2024 17:43:14 +0100
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>,
	Luis Chamberlain <mcgrof@...nel.org>,
	Russ Weight <russ.weight@...ux.dev>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, Mark Brown <broonie@...nel.org>,
	Frank Rowand <frowand.list@...il.com>, Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, devicetree@...r.kernel.org,
	Dent Project <dentproject@...uxfoundation.org>
Subject: Re: [PATCH net-next v5 13/17] net: pse-pd: Use regulator framework
 within PSE framework

On Thu, Mar 21, 2024 at 05:15:24PM +0100, Kory Maincent wrote:
> Hello Oleksij,
> 
> On Mon, 4 Mar 2024 11:31:19 +0100
> Oleksij Rempel <o.rempel@...gutronix.de> wrote:
> 
> > >    
> > > > Should be tested, but if, instead of "vin-supply", we will use
> > > > "pse-supply" it will make most part of pse_regulator.c obsolete.  
> > > 
> > > Don't know, if it is done at the pse-pi node level it may not break
> > > pse_regulator.c. Not sure about it.  
> > 
> > me too. Before your patch set, the regulator topology for PoDL PSE was
> > following:
> > power-source
> >   fixed-regulator
> >      PoDL_PSE-consumer
> > 
> > Now it will be:
> > power-source
> >   fixed-regulator
> >      PoDL_PSE-consumer
> >        PSE-PI-provider
> >          PSE-PI-consumer
> > 
> > By porting porting PSE framework to regulator, probably it make sense to
> > remove two levels of regulators?
> > power-source
> >   fixed-regulator
> >      PSE-PI-consumer
> 
> Sorry, I forgot to reply about this.
> This is specific to pse_regulator driver. Could we tackle this change in another
> patch series when the current patch series got applied?
> Also I don't have the hardware to test it.

ACK, no problem.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |