linux-kernel - Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <879296b4-5186-4170-af3f-971787d28514@sirena.org.uk>
Date: Thu, 21 Mar 2024 16:58:44 +0000
From: Mark Brown <broonie@...nel.org>
To: Karel Balej <balejk@...fyz.cz>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Liam Girdwood <lgirdwood@...il.com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	Duje Mihanović <duje.mihanovic@...le.hr>,
	~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org
Subject: Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

On Thu, Mar 21, 2024 at 05:55:17PM +0100, Karel Balej wrote:
> Lee Jones, 2024-03-21T16:20:45+00:00:
> > On Thu, 21 Mar 2024, Karel Balej wrote:

> > > > > +static const struct regmap_config pm886_i2c_regmap = {
> > > > > +	.reg_bits = 8,
> > > > > +	.val_bits = 8,
> > > > > +	.max_register = PM886_REGMAP_CONF_MAX_REG,
> > > > > +};

> > > > Why is this in here?

> > > Because since I moved the regulators regmap initialization into the
> > > regulators driver, I need to access it from there.

> > So move it into the regulators driver?

> It is used in the MFD driver too for the base regmap.

You shouldn't be creating two regmaps for the same set of registers,
that just opens the potential for confusion.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)