linux-kernel - Re: [PATCH] kbuild: disable pahole multithreading for reproducible builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zf2_fgs0cqW82zEu@x1>
Date: Fri, 22 Mar 2024 14:27:26 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Alan Maguire <alan.maguire@...cle.com>
Cc: Thomas Weißschuh <linux@...ssschuh.net>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Andrii Nakryiko <andrii@...nel.org>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
	Yonghong Song <yonghong.song@...ux.dev>,
	John Fastabend <john.fastabend@...il.com>,
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...gle.com>,
	Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Nicolas Schier <nicolas@...sle.eu>, bpf@...r.kernel.org,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: disable pahole multithreading for reproducible
 builds

On Fri, Mar 22, 2024 at 10:07:00AM +0000, Alan Maguire wrote:
> On 22/03/2024 08:31, Thomas Weißschuh wrote:
> > A BTF type_id is a numeric identifier allocated by pahole through
> > libbpfd. Ids are incremented for each allocation.
> > Running pahole multithreaded makes the sequence of allocations
> > non-deterministic which also makes the type_id itself non-deterministic.
> > As the type_id end up in the binary this breaks reproducibility.
> > 
> > Therefore, if the kernel is built reproducibly as indicated by
> > KBUILD_BUILD_TIMESTAMP, disable threading in pahole.
> > 
> > Fixes: b4f72786429c ("scripts/pahole-flags.sh: Parse DWARF and generate BTF with multithreading.")
> > Fixes: 72d091846de9 ("kbuild: avoid too many execution of scripts/pahole-flags.sh")
> > Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> 
> Yep, we've talked about sorting final BTF in various ways but until that
> is implemented, non-parallel execution of pahole is the best way to get
> reliabily-reproducing BTF ids. We should probably update the pahole

So, the problem is about parallel BTF encoding, not so much about
parallel DWARF loading, which speeds up the whole process and could
continue if we make sure that we feed the BTF encoder in the same order
as when not doing anything in parallel.

I.e. a serial BTF encoding done at the same time as a parallel DWARF
loading would produce a reproducible build faster than doing
_everything_ serially.

The important point would be to feed the btf encoder the DWARF CUs in
the same order as when doing it serially.

No need to order anything, just create a linked list/array of CUs and
then start loading them and leave the BTF encoder go on taking CUs from
that linked list/array in the order they are in vmlinux.

- Arnaldo

> manpage to warn about parallel non-deterministic id allocation in the
> meantime.
> 
> Reviewed-by: Alan Maguire <alan.maguire@...cle.com>
> 
> > ---
> >  scripts/Makefile.btf | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/scripts/Makefile.btf b/scripts/Makefile.btf
> > index 82377e470aed..2356929e62e4 100644
> > --- a/scripts/Makefile.btf
> > +++ b/scripts/Makefile.btf
> > @@ -10,7 +10,10 @@ endif
> >  
> >  pahole-flags-$(call test-ge, $(pahole-ver), 121)	+= --btf_gen_floats
> >  
> > +# threaded execution randomizes BTF type_id allocation, breaking reproducibility
> > +ifeq ($(KBUILD_BUILD_TIMESTAMP),)
> >  pahole-flags-$(call test-ge, $(pahole-ver), 122)	+= -j
> > +endif
> >  
> >  pahole-flags-$(CONFIG_PAHOLE_HAS_LANG_EXCLUDE)		+= --lang_exclude=rust
> >  
> > 
> > ---
> > base-commit: 8e938e39866920ddc266898e6ae1fffc5c8f51aa
> > change-id: 20240322-pahole-reprodicible-02e904e45686
> > 
> > Best regards,
>