linux-kernel - Re: [PATCH] selftests/mm: run_vmtests.sh: Fix hugetlb mem size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <56CA06CD-3F37-4268-B1B1-9C376AF9B136@linux.dev>
Date: Fri, 22 Mar 2024 11:50:50 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: Peter Xu <peterx@...hat.com>
Cc: Linux-MM <linux-mm@...ck.org>,
 LKML <linux-kernel@...r.kernel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Muhammad Usama Anjum <usama.anjum@...labora.com>,
 David Hildenbrand <david@...hat.com>,
 Nico Pache <npache@...hat.com>
Subject: Re: [PATCH] selftests/mm: run_vmtests.sh: Fix hugetlb mem size
 calculation



> On Mar 22, 2024, at 05:50, peterx@...hat.com wrote:
> 
> From: Peter Xu <peterx@...hat.com>
> 
> The script calculates a mininum required size of hugetlb memories, but
> it'll stop working with <1MB huge page sizes, reporting all zeros even if
> huge pages are available.
> 
> In reality, the calculation doesn't really need to be as comlicated either.

                                                               ^
                                                           complicated?

> Make it simpler and work for KB-level hugepages too.
> 
> Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Nico Pache <npache@...hat.com>
> Cc: Muchun Song <muchun.song@...ux.dev>
> Signed-off-by: Peter Xu <peterx@...hat.com>

Reviewed-by: Muchun Song <muchun.song@...ux.dev>

Thanks.