linux-kernel - Re: [PATCH v2 04/13] perf dsos: Add dsos__for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 22 Mar 2024 13:54:06 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, James Clark <james.clark@....com>, 
	Athira Rajeev <atrajeev@...ux.vnet.ibm.com>, Colin Ian King <colin.i.king@...il.com>, 
	Ahelenia Ziemiańska <nabijaczleweli@...ijaczleweli.xyz>, 
	Leo Yan <leo.yan@...ux.dev>, Song Liu <song@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, 
	Liam Howlett <liam.howlett@...cle.com>, Ilkka Koskinen <ilkka@...amperecomputing.com>, 
	Ben Gainey <ben.gainey@....com>, K Prateek Nayak <kprateek.nayak@....com>, 
	Kan Liang <kan.liang@...ux.intel.com>, Yanteng Si <siyanteng@...ngson.cn>, 
	Ravi Bangoria <ravi.bangoria@....com>, Sun Haiyong <sunhaiyong@...ngson.cn>, 
	Changbin Du <changbin.du@...wei.com>, Masami Hiramatsu <mhiramat@...nel.org>, 
	zhaimingbing <zhaimingbing@...s.chinamobile.com>, Paran Lee <p4ranlee@...il.com>, 
	Li Dong <lidong@...o.com>, elfring@...rs.sourceforge.net, 
	Andi Kleen <ak@...ux.intel.com>, Markus Elfring <Markus.Elfring@....de>, 
	Chengen Du <chengen.du@...onical.com>, linux-perf-users@...r.kernel.org, 
	linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH v2 04/13] perf dsos: Add dsos__for_each_dso

On Fri, Mar 22, 2024 at 1:43 PM Namhyung Kim <namhyung@...nel.org> wrote:
>
> Hi Ian,
>
> On Thu, Mar 21, 2024 at 9:03 AM Ian Rogers <irogers@...gle.com> wrote:
> >
> > To better abstract the dsos internals, add dsos__for_each_dso that
> > does a callback on each dso. This also means the read lock can be
> > correctly held.
> >
> > Signed-off-by: Ian Rogers <irogers@...gle.com>
> > ---
[SNIP]
> > diff --git a/tools/perf/util/dsos.c b/tools/perf/util/dsos.c
> > index d269e09005a7..d43f64939b12 100644
> > --- a/tools/perf/util/dsos.c
> > +++ b/tools/perf/util/dsos.c
> > @@ -433,3 +433,19 @@ struct dso *dsos__find_kernel_dso(struct dsos *dsos)
> >         up_read(&dsos->lock);
> >         return res;
> >  }
> > +
> > +int dsos__for_each_dso(struct dsos *dsos, int (*cb)(struct dso *dso, void *data), void *data)
> > +{
> > +       struct dso *dso;
> > +
> > +       down_read(&dsos->lock);
> > +       list_for_each_entry(dso, &dsos->head, node) {
> > +               int err;
> > +
> > +               err = cb(dso, data);
> > +               if (err)
> > +                       return err;
>
> Please break and return the error to release the lock.

Hmm.. I saw this code was replaced by the next patch.
Then probably it'd be ok to leave it.

Thanks,
Namhyung

>
> > +       }
> > +       up_read(&dsos->lock);
> > +       return 0;
> > +}