[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zf39nYJVOH9/J8cs@duo.ucw.cz>
Date: Fri, 22 Mar 2024 22:52:29 +0100
From: Pavel Machek <pavel@....cz>
To: Daniel Hodges <hodges.daniel.scott@...il.com>
Cc: ast@...nel.org, lee@...nel.org, linux-leds@...r.kernel.org,
daniel@...earbox.net, bpf@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] leds: trigger: legtrig-bpf: Add ledtrig-bpf module
Hi!
> This patch adds a led trigger that interfaces with the bpf subsystem. It
> allows for BPF programs to control LED activity through calling bpf
> kfuncs. This functionality is useful in giving users a physical
> indication that a BPF program has performed an operation such as
> handling a packet or probe point.
>
> Signed-off-by: Daniel Hodges <hodges.daniel.scott@...il.com>
> +static int init_bpf(void)
> +{
> + int ret;
> +
> + ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_UNSPEC,
> + &ledtrig_bpf_kfunc_set);
> + ret = register_btf_kfunc_id_set(BPF_PROG_TYPE_TRACING,
> + &ledtrig_bpf_kfunc_set);
Should have ret ?: here, too?
> +static int ledtrig_bpf_init(void)
> +{
> + led_trigger_register_simple("bpf", &ledtrig_bpf);
> +
> + return init_bpf();
> +}
Is it somehow possible to have multiple LEDs hooked to bpf
functionality? I guess someone will want that...
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)
Powered by blists - more mailing lists