[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240322154337.4f78858c@kernel.org>
Date: Fri, 22 Mar 2024 15:43:37 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Aleksandr Mishin <amishin@...rgos.ru>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Kees Cook
<keescook@...omium.org>, Justin Stitt <justinstitt@...gle.com>, Felix
Manlunas <felix.manlunas@...ium.com>, Satanand Burla
<satananda.burla@...ium.com>, Raghu Vatsavayi <raghu.vatsavayi@...ium.com>,
Vijaya Mohan Guvva <vijaya.guvva@...ium.com>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <lvc-project@...uxtesting.org>
Subject: Re: [PATCH net v2] liquidio: Fix potential null pointer dereference
On Fri, 22 Mar 2024 22:57:44 +0300 Aleksandr Mishin wrote:
> In lio_vf_rep_copy_packet() pg_info->page is compared to a NULL value,
> but then it is unconditionally passed to skb_add_rx_frag() which could
> lead to null pointer dereference.
> Fix this bug by moving skb_add_rx_frag() into conditional scope.
The explanation should tell us how the bug can happen, i.e. what
sequence of events leads to null-deref. Not what logic your tool
matched on, perhaps the NULL check is unnecessary.
--
pw-bot: cr
Powered by blists - more mailing lists