linux-kernel - Re: [PATCH] x86, relocs: Ignore relocations in .notes section on walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202403221622.6EA43547F@keescook>
Date: Fri, 22 Mar 2024 16:40:11 -0700
From: Kees Cook <keescook@...omium.org>
To: Borislav Petkov <bp@...en8.de>
Cc: tglx@...utronix.de, Guixiong Wei <weiguixiong@...edance.com>,
	jgross@...e.com, mingo@...hat.com, dave.hansen@...ux.intel.com,
	x86@...nel.org, hpa@...or.com, peterz@...radead.org,
	gregkh@...uxfoundation.org, tony.luck@...el.com,
	adobriyan@...il.com, linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] x86, relocs: Ignore relocations in .notes section on
 walk_relocs

On Fri, Mar 22, 2024 at 08:46:58PM +0100, Borislav Petkov wrote:
> On Tue, Mar 19, 2024 at 09:56:29AM -0700, Kees Cook wrote:
> > > Yes, please. Just send a Reviewed-by and it'll get picked up.
> > 
> > Okay, thanks!
> 
> Dammit, how did this commit land upstream and in stable?!

There are 2 related commits. This one ("... on walk_relocs") isn't in
Linus's tree nor stable.

(Thank you Ingo for taking it now.)

> Forgot to zap it from your tree and sent the branch to Linus anyway?
> 
> Kees, please refrain from taking tip patches in the future. You know how
> this works - get_maintainers.pl.

The earlier patch, commit aaa8736370db ("x86, relocs: Ignore relocations
in .notes section"), landed via my tree. It was sent out on Feb 22nd
(v1[1]) and got a suggestion from HPA and a Review from Juergen Gross.
I sent v2 Feb 27th[2] and it sat ignored for two weeks. Since it was a
10 year old kernel address exposure, I sent it to Linus on Mar 12th[3].

-Kees

[1] https://lore.kernel.org/all/20240222171840.work.027-kees@kernel.org/
[2] https://lore.kernel.org/all/20240227175746.it.649-kees@kernel.org/
[3] https://lore.kernel.org/lkml/202403111702.828C918E55@keescook/

-- 
Kees Cook