linux-kernel - Re: [PATCH] netlink: fix typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 22 Mar 2024 15:58:30 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: gaoxingwang <gaoxingwang1@...wei.com>
Cc: mkubecek@...e.cz, idosch@...dia.com, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, yanan@...wei.com, liaichun@...wei.com
Subject: Re: [PATCH] netlink: fix typo

On Fri, Mar 22, 2024 at 3:26 PM gaoxingwang <gaoxingwang1@...wei.com> wrote:
>
> Add missing colon in coalesce_reply_cb
>
> Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params)

This commit cannot be found in net/net-next tree...

> Signed-off-by: gaoxingwang <gaoxingwang1@...wei.com>
>
> Signed-off-by: gaoxingwang <gaoxingwang1@...wei.com>

nit: two duplicated SoB

> ---
>  netlink/coalesce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/netlink/coalesce.c b/netlink/coalesce.c
> index bc34d3d..bb93f9b 100644
> --- a/netlink/coalesce.c
> +++ b/netlink/coalesce.c

Where is this file? I suspect you're not using the standard mainline?

> @@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
>                  tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
>         show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
>                  tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
> -       show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
> +       show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
>                  tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
>         show_cr();
>
> --
> 2.27.0
>
>