[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240322081036.GL13211@google.com>
Date: Fri, 22 Mar 2024 08:10:36 +0000
From: Lee Jones <lee@...nel.org>
To: Andre Przywara <andre.przywara@....com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
Samuel Holland <samuel@...lland.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Chris Morgan <macromorgan@...mail.com>,
linux-kernel@...r.kernel.org, linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH 0/4] regulator: Add X-Powers AXP717 PMIC support
On Thu, 21 Mar 2024, Lee Jones wrote:
> On Sun, 10 Mar 2024, Andre Przywara wrote:
>
> > This patch series adds support for the X-Powers AXP717 PMIC, which is
> > used recently on new boards with Allwinner SoCs.
> > Allwinner's BSP code often speaks of the AXP2202, this seems to be the
> > same chip, at least a boot0 AXP2202 driver happily drove a chip labelled
> > AXP717.
> >
> > Patch 1 fixes a typo in some macro names for the AXP313a PMIC, I just
> > realised that during some copy&paste action. It's just an identifier
> > rename, so not a backport candidate, I'd say.
> > Patch 2 adds the compatible string to the binding document.
> > Patch 3 is the MFD part, describing the regmap and all the interrupts.
> > So far we support the regulator and power key devices, the USB and
> > charging devices will follow later.
> > Patch 4 adds the voltage regulator rails, this part is crucial to enable
> > any board using this PMIC, as we depend on those rails even for basic
> > devices.
> >
> > Please note that I could not test this driver myself, but had success
> > messages from others. It would be good to hear from Ryan and Chris
> > here on the list, with a Tested-by: tag.
> >
> > This series is based on next-20240308 for now. I will send a rebased
> > update after the merge window, but wanted to start discussion and review
> > now.
> >
> > Please have a look!
> >
> > Cheers,
> > Andre
> >
> > Andre Przywara (4):
> > regulator: axp20x: fix typo-ed identifier
> > dt-bindings: mfd: x-powers,axp152: document AXP717
> > mfd: axp20x: add support for AXP717 PMIC
> > regulator: axp20x: add support for the AXP717
> >
> > .../bindings/mfd/x-powers,axp152.yaml | 2 +
> > drivers/mfd/axp20x-i2c.c | 2 +
> > drivers/mfd/axp20x-rsb.c | 1 +
> > drivers/mfd/axp20x.c | 90 +++++++++++++++++
> > drivers/regulator/axp20x-regulator.c | 94 +++++++++++++++++-
> > include/linux/mfd/axp20x.h | 98 ++++++++++++++++++-
> > 6 files changed, 277 insertions(+), 10 deletions(-)
>
> All applied and sent for build testing. If everything works out, I'll
> send out a pull-request to an immutable branch shortly.
Okay, these are building okay based on v6.8.
I'll send out a PR once I can rebase tem onto v6.9-rc1.
Note to self: ib-mfd-regulator-6.9
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists