linux-kernel - Re: [PATCH] tools/power/turbostat: Fix uncore frequency file string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1980117.DIVbhacDa7@work.fritz.box>
Date: Fri, 22 Mar 2024 13:38:02 +0100
From: Thomas Renninger <trenn@...e.de>
To: Len Brown <lenb@...nel.org>, Justin Ernst <justin.ernst@....com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 Justin Ernst <justin.ernst@....com>
Subject: Re: [PATCH] tools/power/turbostat: Fix uncore frequency file string

On Freitag, 8. März 2024 21:49:57 CET Justin Ernst wrote:
> Running turbostat on a 16 socket HPE Scale-up Compute 3200 (SapphireRapids)
> fails with: turbostat:
> /sys/devices/system/cpu/intel_uncore_frequency/package_010_die_00/current_f
> req_khz: open failed: No such file or directory
> 
> We observe the sysfs uncore frequency directories named:
> ...
> package_09_die_00/
> package_10_die_00/
> package_11_die_00/
> ...
> package_15_die_00/
> 
> The culprit is an incorrect sprintf format string "package_0%d_die_0%d" used
> with each instance of reading uncore frequency files.
> uncore-frequency-common.c creates the sysfs directory with the format
> "package_%02d_die_%02d". Once the package value reaches double digits, the
> formats diverge.
Yep, currently in:
drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c
line 238.

Looks like the proper bugfix.
 
> Change each instance of "package_0%d_die_0%d" to "package_%02d_die_%02d".
> 
> Signed-off-by: Justin Ernst <justin.ernst@....com>

Reviewed-by: Thomas Renninger <trenn@...e.de>

       Thomas
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)