linux-kernel - Re: [PATCH] dmaengine: owl: fix register access functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o7b62xsy.fsf@48ers.dk>
Date: Fri, 22 Mar 2024 14:36:29 +0100
From: Peter Korsgaard <peter@...sgaard.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Vinod Koul <vkoul@...nel.org>,  Andreas Färber
 <afaerber@...e.de>,
  Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,  Nathan
 Chancellor <nathan@...nel.org>,  Arnd Bergmann <arnd@...db.de>,  Nick
 Desaulniers <ndesaulniers@...gle.com>,  Bill Wendling <morbo@...gle.com>,
  Justin Stitt <justinstitt@...gle.com>,  Uwe Kleine-König
 <u.kleine-koenig@...gutronix.de>,  Randy Dunlap <rdunlap@...radead.org>,
  Rob Herring <robh@...nel.org>,  Zhang Jianhua <chris.zjh@...wei.com>,
  dmaengine@...r.kernel.org,  linux-arm-kernel@...ts.infradead.org,
  linux-actions@...ts.infradead.org,  linux-kernel@...r.kernel.org,
  llvm@...ts.linux.dev
Subject: Re: [PATCH] dmaengine: owl: fix register access functions

>>>>> "Arnd" == Arnd Bergmann <arnd@...nel.org> writes:

 > From: Arnd Bergmann <arnd@...db.de>
 > When building with 'make W=1', clang notices that the computed register
 > values are never actually written back but instead the wrong variable
 > is set:

 > drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
 >   244 |         u32 regval;
 >       |             ^
 > drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
 >   268 |         u32 regval;
 >       |             ^

 > Change these to what was most likely intended.

 > Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver")
 > Signed-off-by: Arnd Bergmann <arnd@...db.de>

Good catch!

Reviewed-by: Peter Korsgaard <peter@...sgaard.com>

-- 
Bye, Peter Korsgaard