linux-kernel - Re: [PATCH net-next v5 13/17] net: pse-pd: Use regulator framework within PSE framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 22 Mar 2024 15:22:26 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Jonathan Corbet <corbet@....net>, Luis Chamberlain
 <mcgrof@...nel.org>, Russ Weight <russ.weight@...ux.dev>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki"
 <rafael@...nel.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
 Mark Brown <broonie@...nel.org>, Frank Rowand <frowand.list@...il.com>,
 Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 devicetree@...r.kernel.org, Dent Project <dentproject@...uxfoundation.org>
Subject: Re: [PATCH net-next v5 13/17] net: pse-pd: Use regulator framework
 within PSE framework

On Fri, 22 Mar 2024 15:07:45 +0100
Oleksij Rempel <o.rempel@...gutronix.de> wrote:

> Hay Kory,
> 
> On Fri, Mar 22, 2024 at 11:39:50AM +0100, Kory Maincent wrote:
> > Hello Oleksij,
> > 
> > On Thu, 21 Mar 2024 17:43:14 +0100
> > Oleksij Rempel <o.rempel@...gutronix.de> wrote:
> >   
> > > On Thu, Mar 21, 2024 at 05:15:24PM +0100, Kory Maincent wrote:  
> > > > Hello Oleksij,
> > > > Sorry, I forgot to reply about this.
> > > > This is specific to pse_regulator driver. Could we tackle this change in
> > > > another patch series when the current patch series got applied?
> > > > Also I don't have the hardware to test it.    
> > > 
> > > ACK, no problem.  
> > 
> > I have a question unrelated to this.
> > Why do you add refcount on the pse_control struct?
> > The pse control is related to the RJ45 port. Each port is exclusively
> > related to one pse control.
> > Shouldn't we return an error in case of two get of the same pse control
> > index? Do you see use cases where a pse control could be get two times?  
> 
> I assume, any instance which need coordinate PSE behavior with own actions.
> For example - PHY will probably need to coordinate PHY state with PSE PD
> classification process.

Indeed, I was focused on devicetree and didn't thought of coordination
between PHY and PSE. Thanks for your reply.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com