[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zf2UwOGU2N7BfTTw@hovoldconsulting.com>
Date: Fri, 22 Mar 2024 15:25:04 +0100
From: Johan Hovold <johan@...nel.org>
To: Abel Vesa <abel.vesa@...aro.org>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Rob Clark <robdclark@...il.com>,
Abhinav Kumar <quic_abhinavk@...cinc.com>,
Sean Paul <sean@...rly.run>,
Marijn Suijten <marijn.suijten@...ainline.org>,
David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Kuogee Hsieh <quic_khsieh@...cinc.com>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
freedreno@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] drm/msm/dp: Add support for determining the
eDP/DP mode from DT
On Fri, Mar 22, 2024 at 04:15:23PM +0200, Abel Vesa wrote:
> On 24-03-22 15:38:03, Dmitry Baryshkov wrote:
> > On Fri, 22 Mar 2024 at 15:36, Abel Vesa <abel.vesa@...aro.org> wrote:
> > > On 24-03-22 15:30:54, Dmitry Baryshkov wrote:
> > > > On Fri, 22 Mar 2024 at 15:22, Abel Vesa <abel.vesa@...aro.org> wrote:
> > > > > +static int dp_display_get_connector_type(struct platform_device *pdev,
> > > > > + const struct msm_dp_desc *desc)
> > > > > +{
> > > > > + struct device *dev = &pdev->dev;
> > > > > + struct device_node *aux_bus;
> > > > > + struct device_node *panel;
> > > > > + int ret = DRM_MODE_CONNECTOR_DisplayPort;
> > > > > +
> > > > > + /* legacy platforms specify connector type in match data */
> > > > > + if (desc->connector_type == DRM_MODE_CONNECTOR_eDP ||
> > > > > + desc->connector_type == DRM_MODE_CONNECTOR_DisplayPort)
> > > >
> > > > misaligned
> > > >
> > >
> > > Sure, will fix.
> > >
> > > > > + return desc->connector_type;
> > > >
> > > > Can we drop this part completely?
> > > >
> > >
> > > You mean the whole if clause? How should we handle the legacy approach
> > > then?
> >
> > Legacy platforms still have the aux-bus/panel. so they should be
> > handled by the check below.
> >
>
> Oh, in that case we can drop the connector_type from every desc for all
> platforms.
Guys, please trim your replies!
Johan
Powered by blists - more mailing lists