linux-kernel - Re: [PATCH v3 1/2] Documentation: coding-style: ask function-like macros to evaluate parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d965b3a-c857-4498-aea9-5a3ad8ad5b76@sirena.org.uk>
Date: Fri, 22 Mar 2024 14:33:03 +0000
From: Mark Brown <broonie@...nel.org>
To: Barry Song <21cnbao@...il.com>
Cc: corbet@....net, workflows@...r.kernel.org, linux-doc@...r.kernel.org,
	apw@...onical.com, joe@...ches.com, dwaipayanray1@...il.com,
	lukas.bulwahn@...il.com, linux-kernel@...r.kernel.org,
	Barry Song <v-songbaohua@...o.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chris Zankel <chris@...kel.net>,
	Huacai Chen <chenhuacai@...ngson.cn>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Guenter Roeck <linux@...ck-us.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Max Filippov <jcmvbkbc@...il.com>
Subject: Re: [PATCH v3 1/2] Documentation: coding-style: ask function-like
 macros to evaluate parameters

On Fri, Mar 22, 2024 at 09:49:36PM +1300, Barry Song wrote:

> The driver code, for itself, seems be quite innocent and placing
> maybe_unused seems pointless,
> 
>  struct page *dst_page = sg_page(req->dst);
> 
>  for (i = 0; i < nr_pages; i++)
>  	flush_dcache_page(dst_page + i);
> 
> And it should be independent of architectural implementation
> differences.
> 
> Let's provide guidance on coding style for requesting parameter
> evaluation or proposing the migration to a static inline
> function.

Reviewed-by: Mark Brown <broonie@...nel.org>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)