linux-kernel - Re: [PATCH] ipv6: fib: hide unused 'pn' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6c0bf7e-bd8f-49f4-abb0-df04fe0e4333@kernel.org>
Date: Fri, 22 Mar 2024 08:36:44 -0600
From: David Ahern <dsahern@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, YOSHIFUJI Hideaki
 <yoshfuji@...ux-ipv6.org>, Ville Nuorvala <vnuorval@....hut.fi>
Cc: Arnd Bergmann <arnd@...db.de>, Kui-Feng Lee <thinker.li@...il.com>,
 Breno Leitao <leitao@...ian.org>, Kunwu Chan <chentao@...inos.cn>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipv6: fib: hide unused 'pn' variable

On 3/22/24 7:14 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When CONFIG_IPV6_SUBTREES is disabled, the only user is hidden, causing
> a 'make W=1' warning:
> 
> net/ipv6/ip6_fib.c: In function 'fib6_add':
> net/ipv6/ip6_fib.c:1388:32: error: variable 'pn' set but not used [-Werror=unused-but-set-variable]
> 
> Add another #ifdef around the variable declaration, matching the other
> uses in this file.
> 
> Fixes: 66729e18df08 ("[IPV6] ROUTE: Make sure we have fn->leaf when adding a node on subtree.")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  net/ipv6/ip6_fib.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Reviewed-by: David Ahern <dsahern@...nel.org>