[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <hcpgho3xrkxas55c5isxi7mwusdjbxkyxlt74r72gfxuunzikx@jxiyumioezb6>
Date: Fri, 22 Mar 2024 09:44:57 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Johan Hovold <johan+linaro@...nel.org>
Cc: Marcel Holtmann <marcel@...tmann.org>,
Luiz Augusto von Dentz <luiz.dentz@...il.com>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
cros-qcom-dts-watchers@...omium.org, Konrad Dybcio <konrad.dybcio@...aro.org>,
Johan Hedberg <johan.hedberg@...il.com>, Balakrishna Godavarthi <quic_bgodavar@...cinc.com>,
Matthias Kaehlcke <mka@...omium.org>, Douglas Anderson <dianders@...omium.org>,
Rocky Liao <quic_rjliao@...cinc.com>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org,
Rob Clark <robdclark@...omium.org>
Subject: Re: [PATCH v4 2/4] arm64: dts: qcom: sc7180-trogdor: mark bluetooth
address as broken
On Wed, Mar 20, 2024 at 08:55:52AM +0100, Johan Hovold wrote:
> Several Qualcomm Bluetooth controllers lack persistent storage for the
> device address and instead one can be provided by the boot firmware
> using the 'local-bd-address' devicetree property.
>
> The Bluetooth bindings clearly states that the address should be
> specified in little-endian order, but due to a long-standing bug in the
> Qualcomm driver which reversed the address some boot firmware has been
> providing the address in big-endian order instead.
>
> The boot firmware in SC7180 Trogdor Chromebooks is known to be affected
> so mark the 'local-bd-address' property as broken to maintain backwards
> compatibility with older firmware when fixing the underlying driver bug.
>
> Note that ChromeOS always updates the kernel and devicetree in lockstep
> so that there is no need to handle backwards compatibility with older
> devicetrees.
>
> Fixes: 7ec3e67307f8 ("arm64: dts: qcom: sc7180-trogdor: add initial trogdor and lazor dt")
> Cc: stable@...r.kernel.org # 5.10
> Cc: Rob Clark <robdclark@...omium.org>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
Acked-by: Bjorn Andersson <andersson@...nel.org>
Reviewed-by: Bjorn Andersson <andersson@...nel.org>
Please merge this through the BT tree, together with the other patches.
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 46aaeba28604..ebe37678102f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -943,6 +943,8 @@ bluetooth: bluetooth {
> vddrf-supply = <&pp1300_l2c>;
> vddch0-supply = <&pp3300_l10c>;
> max-speed = <3200000>;
> +
> + qcom,local-bd-address-broken;
> };
> };
>
> --
> 2.43.2
>
Powered by blists - more mailing lists