linux-kernel - Re: [PATCH v3 4/4] arm64: dts: S32G3: Introduce device tree for S32G-VNP-RDB3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52b6976d-2903-4480-b171-fa16b99bc88e@oss.nxp.com>
Date: Fri, 22 Mar 2024 16:52:04 +0200
From: Ghennadi Procopciuc <ghennadi.procopciuc@....nxp.com>
To: Wadim Mueller <wafgo01@...il.com>
Cc: Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>,
 Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, NXP Linux Team <linux-imx@....com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, Chester Lin <chester62515@...il.com>,
 Andreas Färber <afaerber@...e.de>,
 Matthias Brugger <mbrugger@...e.com>, NXP S32 Linux Team <s32@....com>,
 Tim Harvey <tharvey@...eworks.com>,
 Alexander Stein <alexander.stein@...tq-group.com>,
 Gregor Herburger <gregor.herburger@...tq-group.com>,
 Marek Vasut <marex@...x.de>, Hugo Villeneuve <hvilleneuve@...onoff.com>,
 Marco Felsch <m.felsch@...gutronix.de>,
 Markus Niebel <Markus.Niebel@...tq-group.com>,
 Matthias Schiffer <matthias.schiffer@...group.com>,
 Stefan Wahren <stefan.wahren@...rgebyte.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Philippe Schenker <philippe.schenker@...adex.com>,
 Li Yang <leoyang.li@....com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v3 4/4] arm64: dts: S32G3: Introduce device tree for
 S32G-VNP-RDB3

On 3/21/24 17:41, Wadim Mueller wrote:
> +++ b/arch/arm64/boot/dts/freescale/s32g3.dtsi
> @@ -0,0 +1,237 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later

Please use the dual license model (GPL-2.0+ OR BSD-3-Clause) for device
tree files, as the TF-A version of these files [0] already uses this
license. Using a consistent license is needed to keep files in sync
between upstream versions of Linux and TF-A for S32G in the future.

> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.

This paragraph is already implied by the SPDX tag.

> + *
> + */> +
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +/ {

Missing empty line here between header include and '{'?

[0]
https://github.com/nxp-auto-linux/arm-trusted-firmware/blob/release/bsp39.0-2.5/fdts/s32g3.dtsi#L1

Regards,
Ghennadi