[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240322151633.16485-1-chandrapratap3519@gmail.com>
Date: Fri, 22 Mar 2024 20:46:33 +0530
From: Chandra Pratap <chandrapratap3519@...il.com>
To:
Cc: sudipm.mukherjee@...il.com,
dan.carpenter@...aro.org,
teddy.wang@...iconmotion.com,
gregkh@...uxfoundation.org,
linux-fbdev@...r.kernel.org,
linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org,
outreachy@...ts.linux.dev,
Chandra Pratap <chandrapratap3519@...il.com>
Subject: [PATCH v3] staging: sm750fb: Replace comparisons with NULL and 0
Replace '(opt != NULL)' with '(opt)' and '(*opt != 0)'
with '(*opt != '\0')' to adhere to the coding standards.
Signed-off-by: Chandra Pratap <chandrapratap3519@...il.com>
---
Please ignore the other v3 patch I sent, I forgot to write
the change log in that patch. Apologies for any incovenienece
caused.
Changes in v2:
- Update the commit message to reflect the changes better
- Replace (*opt) with (*opt != '\0')
Changes in v3:
- Remove unncessary spacing
drivers/staging/sm750fb/sm750.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 04c1b32a22c5..c4b944f82fb9 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -926,7 +926,7 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src)
goto NO_PARAM;
}
- while ((opt = strsep(&src, ":")) != NULL && *opt != 0) {
+ while ((opt = strsep(&src, ":")) && *opt != '\0') {
dev_info(&sm750_dev->pdev->dev, "opt=%s\n", opt);
dev_info(&sm750_dev->pdev->dev, "src=%s\n", src);
@@ -1147,7 +1147,7 @@ static int __init lynxfb_setup(char *options)
* strsep() updates @options to pointer after the first found token
* it also returns the pointer ahead the token.
*/
- while ((opt = strsep(&options, ":")) != NULL) {
+ while ((opt = strsep(&options, ":"))) {
/* options that mean for any lynx chips are configured here */
if (!strncmp(opt, "noaccel", strlen("noaccel"))) {
g_noaccel = 1;
--
2.34.1
Powered by blists - more mailing lists