linux-kernel - fs/nfs/read.c:51:2-7: WARNING: NULL check before some freeing functions is not needed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202403222313.MSx9nW9B-lkp@intel.com>
Date: Fri, 22 Mar 2024 23:44:04 +0800
From: kernel test robot <lkp@...el.com>
To: Anna Schumaker <Anna.Schumaker@...app.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: fs/nfs/read.c:51:2-7: WARNING: NULL check before some freeing
 functions is not needed.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8e938e39866920ddc266898e6ae1fffc5c8f51aa
commit: 303a78052091c81e9003915c521fdca1c7e117af NFSv4.2: Rework scratch handling for READ_PLUS (again)
date:   7 months ago
config: x86_64-randconfig-101-20240322 (https://download.01.org/0day-ci/archive/20240322/202403222313.MSx9nW9B-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403222313.MSx9nW9B-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> fs/nfs/read.c:51:2-7: WARNING: NULL check before some freeing functions is not needed.

vim +51 fs/nfs/read.c

    47	
    48	static void nfs_readhdr_free(struct nfs_pgio_header *rhdr)
    49	{
    50		if (rhdr->res.scratch != NULL)
  > 51			kfree(rhdr->res.scratch);
    52		kmem_cache_free(nfs_rdata_cachep, rhdr);
    53	}
    54	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki