linux-kernel - Re: [PATCH] irqflags: explicitly ignore lockdep_hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240322154942.XIaqXpjU@linutronix.de>
Date: Fri, 22 Mar 2024 16:49:42 +0100
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Arnd Bergmann <arnd@...db.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Kent Overstreet <kent.overstreet@...ux.dev>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqflags: explicitly ignore lockdep_hrtimer_exit()
 argument

On 2024-03-22 14:20:41 [+0100], Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When building with 'make W=1' but CONFIG_TRACE_IRQFLAGS=n, the
> unused argument to lockdep_hrtimer_exit() causes a warning:
> 
> kernel/time/hrtimer.c:1655:14: error: variable 'expires_in_hardirq' set but not used [-Werror=unused-but-set-variable]
> 
> This is intentional behavior, so add a cast to void to shut up the warning.
> 
> Fixes: 73d20564e0dc ("hrtimer: Don't dereference the hrtimer pointer after the callback")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Hmm. Seems I forgot about it
   https://lore.kernel.org/all/20231120153953.kGBSHe5j@linutronix.de/

Maybe we could the commit message from the referenced patch. Either way,
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Sebastian