linux-kernel - Re: [PATCH v2] efi: fix panic in kdump kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXF0oM4CZM6GBQ+JNdk0ipf62cVJWjaR7Qy8YEU2B6=MVg@mail.gmail.com>
Date: Sat, 23 Mar 2024 14:15:50 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: Oleksandr Tymoshenko <ovt@...gle.com>
Cc: Johan Hovold <johan+linaro@...nel.org>, stable@...r.kernel.org, 
	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] efi: fix panic in kdump kernel

On Sat, 23 Mar 2024 at 08:33, Oleksandr Tymoshenko <ovt@...gle.com> wrote:
>
> Check if get_next_variable() is actually valid pointer before
> calling it. In kdump kernel this method is set to NULL that causes
> panic during the kexec-ed kernel boot.
>
> Tested with QEMU and OVMF firmware.
>
> Fixes: bad267f9e18f ("efi: verify that variable services are supported")
> Cc: stable@...r.kernel.org
> Signed-off-by: Oleksandr Tymoshenko <ovt@...gle.com>

Thanks. Queued as a fix.

> ---
> Changes in v2:
>   - Style fix
>   - Added Cc: stable
>   - Added Fixes: trailer
> ---
>  drivers/firmware/efi/efi.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> index 8859fb0b006d..fdf07dd6f459 100644
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -203,6 +203,8 @@ static bool generic_ops_supported(void)
>
>         name_size = sizeof(name);
>
> +       if (!efi.get_next_variable)
> +               return false;
>         status = efi.get_next_variable(&name_size, &name, &guid);
>         if (status == EFI_UNSUPPORTED)
>                 return false;
> --
> 2.44.0.396.g6e790dbe36-goog
>