linux-kernel - Re: [PATCH V3] irqchip/loongson-pch-pic: Update interrupt registration policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734sghfya.ffs@tglx>
Date: Sat, 23 Mar 2024 21:05:17 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Tianyang Zhang <zhangtianyang@...ngson.cn>, chenhuacai@...nel.org,
 jiaxun.yang@...goat.com
Cc: linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org, Baoqi Zhang
 <zhangbaoqi@...ngson.cn>, Biao Dong <dongbiao@...ngson.cn>
Subject: Re: [PATCH V3] irqchip/loongson-pch-pic: Update interrupt
 registration policy

Tianyang!

On Fri, Mar 22 2024 at 18:14, Tianyang Zhang wrote:

Please do not top-post. See the 'Top-posting' chapter in:
https://people.kernel.org/tglx/notes-about-netiquette 

> Regarding "WHY", my understanding is that a convincing reason is needed 
> to explain the necessity of this patch.

Yes.

> If so, can the last paragraph "This will be more conducive to fully 
> utilizing existing vectors to support more devices."
>
> be considered a simple explanation?

Kinda, but ideally you describe it in a way that there is context for
the reader. Like this:

  The fixed mapping between the LS7A interrupt source and the HT
  interrupt vector prevents the utilization of the full interrupt vector
  space which limits the number of devices in a system

  Replace the fixed mapping with a dynamic mapping which allocates a
  vector when an interrupt source is set up. This avoids that unused
  sources prevent vectors from being used for other devices.

See?

Thanks,

        tglx