linux-kernel - Re: [PATCH v3 1/5] dt-bindings: mfd: Add rk816 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bfed075-0228-44d9-84a0-2adba47b86e4@gmail.com>
Date: Sat, 23 Mar 2024 22:17:58 +0100
From: Alex Bee <knaerzche@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Lee Jones <lee@...nel.org>, Chris Zhong <zyw@...k-chips.com>,
 Zhang Qing <zhangqing@...k-chips.com>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
 Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Heiko Stuebner <heiko@...ech.de>, Linus Walleij <linus.walleij@...aro.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v3 1/5] dt-bindings: mfd: Add rk816 binding


Am 23.03.24 um 15:32 schrieb Krzysztof Kozlowski:
> On 23/03/2024 14:27, Alex Bee wrote:
>> Add DT binding document for Rockchip's RK816 PMIC
>>
>> Signed-off-by: Alex Bee <knaerzche@...il.com>
>
>> +  regulators:
>> +    type: object
>> +    patternProperties:
>> +      '^(boost|dcdc[1-4]|ldo[1-6]|otg-switch)$':
>> +        type: object
>> +        $ref: /schemas/regulator/regulator.yaml#
>> +        unevaluatedProperties: false
> This is good.
>
>> +    unevaluatedProperties: false
> I missed it last time, apologies. This (second) unevaluated should be
> "additionalProperties: false" instead.
Alright. Since there are no driver changes required for this change, I'll
give the other maintainers some time to review and fix it alongside in v4.

Alex

> With this fixed:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
>
> Best regards,
> Krzysztof
>